[WFLY-22003] Replace JPA initialization with JDBC CDI bean - #1197

Personally I dislike the usage of an EJB for this, I know this was suggested in the original JIRA but EJB is kind of legacy and considered an expensive resource, I suggest instead either:

1. In case DB initialization separated from the Servlet is prefered, to turn DatabaseInitializer into a CDI bean that observes app initialization:

@ApplicationScoped
public class DatabaseInitializer {
    ...
    public void initializeDatabase(@Observes @Initialized(ApplicationScoped.class) Object init) {
       ...
    }
    ...
}

2. Use nothing else than the existing Servlet, overriding its init() method, where you will invoke DatabaseInitializer, and changing the WebServlet annotation to load-init on startup:

@WebServlet(value = "/SecuredServlet", loadOnStartup = 1)
@ServletSecurity(@HttpConstraint(rolesAllowed = { "quickstarts" }))
public class SecuredServlet extends HttpServlet {
    ...
    @Resource(lookup = "java:jboss/datasources/ServletSecurityDS")
    private DataSource dataSource;

    @Override
    public void init() throws ServletException {
        new DatabaseInitializer(dataSource).initializeDatabase();
    }
    ...
}

Either requires no changes to the CLI script, or aditional dependencies.

PS: Ken remarks would still need to be considered.

Thank you @emmartins and @luck3y for your comments. I have since implemented everything, please let me know if everything is good or if changes need to be done.

@Riovo please squash all commits into one too :)

@Riovo please squash all commits into one too :)

Hehe will do, thank you for you time :)

@darranl

LGTM @Riovo, I requested review from @kstekovi too, he was the original issue[1] reporter.

[1] https://redhat.atlassian.net/browse/JBEAP-33412

LGTM overall, one non-blocking nit: insertTestData() runs each INSERT with auto-commit on, and userExists() only gates on the USERS row. If a statement fails mid-sequence (e.g. between the USERS and ROLES inserts), a later redeploy would see quickstartUser already present and skip re-inserting the missing ROLES/USERS_ROLES rows.

Low risk given the small dataset, but conn.setAutoCommit(false) + commit at the end / rollback on SQLException would make the whole insert block atomic and avoid that edge case. Up to you — fine to merge as-is either way.